refactor: filter discovery artworks and use seenArtworks - Githubissues

artsy / metaphysics

Artsy's GraphQL API

MIT License

360 stars 89 forks source link

refactor: filter discovery artworks and use seenArtworks #6161

Closed mc-jones closed 2 weeks ago

mc-jones commented 2 weeks ago

This PR follow https://github.com/artsy/quantum/pull/38 and does two things:

It changes the concept of disliked to seen for the reasons outlined in the above PR.
It filters out seenArtworks AND likedArtworks from the final artwork results.

Considerations

Regarding the filtering, this does mean that we can (and likely will) get less results than any limit we set. Maybe this is fine, but just want to call it out. Also this may not be a final filtering strategy. Just the naive approach to keep things moving.

DO NOT MERGE UNTIL THE SCHEMA CHANGES IN https://github.com/artsy/quantum/pull/38 have been applied