artsy / palette-mobile

Artsy's Design System on Mobile
19 stars 2 forks source link

feat: add select/copy support to text fields by default #244

Closed brainbicycle closed 2 months ago

brainbicycle commented 2 months ago

This PR resolves []

Description

This just sets selectable prop to true by default for Text components. Other option is to set to false by default and selectively enable in places we want it, are there places we don't want it?

Before ![not-selectable](https://github.com/artsy/palette-mobile/assets/49686530/d8d5ef55-7add-4808-8e7f-2dec565825a7)
After ![selectable](https://github.com/artsy/palette-mobile/assets/49686530/0a261e30-538e-40e1-acc5-adcda371f2c6)
oxaudo commented 2 months ago

🎉 !

artsyit commented 2 months ago

:rocket: PR was released in v13.2.23 :rocket: