search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(usefocuslock): uses a more accurate method of determining focusable #1262

Closed dzucconi closed 1 year ago

dzucconi commented 1 year ago

As it happens, determining whether or not an element can be focused is non-trivial. My selector here was actually allowing for some disabled elements to occupy tab stops, which was causing some elements to retain focus for an extra tab. This pulls in the tabbable library which implements a more comprehensive method of determining focusability.

artsyit commented 1 year ago

:rocket: PR was released in @artsy/palette-charts@28.6.1, @artsy/palette@29.6.1 :rocket: