search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(autocompleteinput): adjusts height when filtering results #1298

Closed dzucconi closed 1 year ago

dzucconi commented 1 year ago

This addresses an issue that @MrSltun brought up wherein the new phone number input wherein filtering results wouldn't change the dropdown anchor point; so if the dropdown was flipped so that results were above it, filtering them would leave the dropdown anchored to the top.

Edit: I went with a simpler solution for heights: it appears that generally for the combobox pattern, adjusting the drawer size isn't necessarily desirable. Instead I've added support for responsive props and simplified the code somewhat.

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @artsy/palette-charts@32.1.1-canary.1298.27720.0 npm install @artsy/palette@33.1.1-canary.1298.27720.0 # or yarn add @artsy/palette-charts@32.1.1-canary.1298.27720.0 yarn add @artsy/palette@33.1.1-canary.1298.27720.0 ```
dzucconi commented 1 year ago

https://github.com/artsy/palette/assets/112297/20168872-ee9e-45cc-a0c7-fb6174544691

artsyit commented 1 year ago

:rocket: PR was released in @artsy/palette-charts@32.1.1, @artsy/palette@33.1.1 :rocket: