search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(EMI-1372): Fix Autofill background issue in the new inputs #1317

Closed MrSltun closed 11 months ago

MrSltun commented 1 year ago

This PR resolves EMI-1372

[!IMPORTANT] This PR will be merged to #1250

Description

This PR updates the background of the label to not interfere with the autofill feature

[!NOTE] No structural changes were made, only visual ones

Screenshots & Videos

Autofill comparison

Screenshot
Before image
After image

Animation changes (New)

Before After

Changed inputs

Element Screenshot
Input image
Phone Input image
Select image
TextArea image
damassi commented 1 year ago

Ooh, the before feels cleaner! Second @erikdstock's comment -- if we can avoid the overlap that might work, but I do think we need that nice background (or something). I know (personally) the overlapping + opacity would jump out to my eye every time I used the input. I see the trouble tho...

This:

Screenshot 2023-10-02 at 1 07 02 PM
dzucconi commented 1 year ago

Nice — I suspect you could avoid the overlap by shortening the transition while adding a transition-delay?

dzucconi commented 1 year ago

It's weird no matter what, but this is an improvement for sure.

MrSltun commented 12 months ago

I just updated the animation of the background, let me know what you think of it now :)

damassi commented 12 months ago

@MrSltun - screenshots up to date with latest changes? 👁️

MrSltun commented 11 months ago

@damassi Yes it is the latest :)

I will merge this within 2 hours if no one minds :)

artsyit commented 11 months ago

:rocket: PR was released in @artsy/palette-charts@36.0.0, @artsy/palette@37.0.0 :rocket: