search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(EMI-1373): Fix Select issues with Firefox #1322

Closed MrSltun closed 11 months ago

MrSltun commented 11 months ago

This PR resolves EMI-1373

[!IMPORTANT] This PR will be merged to #1250

Description

This PR solves the issue with :has pseudo-class not being supported by Firefox by applying the styles using JS instead of CSS selectors

Videos

Before After
iskounen commented 11 months ago

This bug can be reproduced with the Price Range selector on the Account Settings page in Force, so we can test it there once this is merged.

MrSltun commented 11 months ago

I'll merge this in an hour if no one objects!

artsyit commented 11 months ago

:rocket: PR was released in @artsy/palette-charts@36.0.0, @artsy/palette@37.0.0 :rocket: