search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(dia-240): optimize tooltip when inactive #1329

Closed dzucconi closed 11 months ago

dzucconi commented 11 months ago

Closes DIA-240

While although I cannot replicate a crash, no matter how many objects appear on page. I was seeing significant frame drops when resizing the window prior to this change, starting at around 3000 instances.

That said: obviously hundreds or thousands of components should never be in the DOM period and we should virtualize that list anyway. But, this should help.

dzucconi commented 11 months ago

Going to merge. Give this a whirl to see if the bug can still be replicated.

artsyit commented 11 months ago

:rocket: PR was released in @artsy/palette-charts@35.3.1, @artsy/palette@36.3.1 :rocket: