search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(EMI-1561): Update "*required" color when the element is disabled #1333

Closed MrSltun closed 11 months ago

MrSltun commented 11 months ago

This PR resolves EMI-1561

Description

This PR updates the color of the "* Required" text under the input elements to be black30 to match the disabled colors of the borders and the label

Screenshots

Before After
Input image image
Select image image
Phone Input image image
MultiSelect image image
TextArea image image
dzucconi commented 11 months ago

Very surprised we're using inaccessible text colors here?

dzucconi commented 11 months ago

Oh, the whole thing is disabled! This is fine.

artsyit commented 11 months ago

:rocket: PR was released in @artsy/palette-charts@36.0.0, @artsy/palette@37.0.0 :rocket: