search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(drawer): renders using portal #1335

Closed dzucconi closed 10 months ago

dzucconi commented 10 months ago

I was expecting this to be more complicated but there's not much to this. I still think we could remove/append the whole thing from the DOM instead of it lying dormant but this should work for our purposes. Will check it out with a canary.

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @artsy/palette-charts@36.0.1-canary.1335.29422.0 npm install @artsy/palette@37.0.1-canary.1335.29422.0 # or yarn add @artsy/palette-charts@36.0.1-canary.1335.29422.0 yarn add @artsy/palette@37.0.1-canary.1335.29422.0 ```
artsyit commented 10 months ago

:rocket: PR was released in @artsy/palette-charts@36.0.1, @artsy/palette@37.0.1 :rocket: