search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

chore: support dotted pill #1336

Closed MounirDhahri closed 10 months ago

MounirDhahri commented 10 months ago

Conversation thread: https://artsy.slack.com/archives/C05EQL4R5N0/p1701182070690769?thread_ts=1700759129.374419&cid=C05EQL4R5N0

This PR adds the dotted version of the Pill component. This comes as a request from design. The component is used here https://www.figma.com/file/lVbIxbnH2IUk1K1FoxyFHV/Filters-and-Alerts-redesign?type=design&node-id=273-47116&mode=dev

Palette Guidelines image

Demo

https://github.com/artsy/palette/assets/11945712/8c0256cf-3ffe-4b96-a177-4724909c24b8

dzucconi commented 10 months ago

AFK right now but: can it be added to the Figma design system?

MounirDhahri commented 10 months ago

@dzucconi Sure, I will ask Barney

MounirDhahri commented 10 months ago

Made my PR a draft until Barney adds the pill to palette

dzucconi commented 10 months ago

Why wouldn't the active state be relevant? It can be clicked right? Also strange is I'd expect this dotted thing to mean disabled.

MounirDhahri commented 10 months ago

@dzucconi Agree with that- I am still waiting for specs to come from design with all the pill states.

MounirDhahri commented 10 months ago

Updated style to match the new specs from the Design team

artsyit commented 10 months ago

:rocket: PR was released in @artsy/palette-charts@36.1.0, @artsy/palette@37.1.0 :rocket: