search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

WIP => refactor(popover): New positioning engine #1345

Closed damassi closed 9 months ago

damassi commented 9 months ago

WIP

dzucconi commented 9 months ago

Keep in mind we'd want to refactor everything that uses usePosition

damassi commented 9 months ago

Right, yeah I just wanted to throw up something that (kinda) works to see what the crossover might be. I would imagine we'd simply replace usePosition internals with this to keep the same api, but this is more in your court.

@dzucconi - Q: if this is a big project (and it seems like it is) would you be open to pulling down volt 2 and updating Layout to work as expected, where body scrolls instead of this wack inner div? I imagine that would be a 10m change for you, and that would push the necessity of this refactor out.

dzucconi commented 9 months ago

Yeah that sounds reasonable. Will take a look tomorrow AM

damassi commented 9 months ago

Thanks so much -- just be sure to boot volt 1 before starting volt 2, and everything should be good to dev in. (Can just push to my progressive onboarding branch, as the tooltips and so on are all ready to go) 👍 🙏