search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(button): avoids passing the loading prop to the underlying dom node #1355

Closed dzucconi closed 8 months ago

dzucconi commented 8 months ago

Closes DIA-387

This just renames the loading prop on the container to match the transient props API in SC5. It doesn't actually work as a transient prop in this case because we are on 4, but it suppresses the warning regardless because it's not passing anything to loading, which is a native attribute.

artsyit commented 8 months ago

:rocket: PR was released in @artsy/palette-charts@36.3.3, @artsy/palette@37.3.3 :rocket:

damassi commented 8 months ago

huge quality of life improvement. Thank you!