search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(tooltip): correctly handles positioning edge case by skipping when inactive #1356

Closed dzucconi closed 8 months ago

dzucconi commented 8 months ago

We noticed that on some pages with Tooltip components in right sidebars, we would see the tooltip dramatically positioned offscreen. @tam-kis noticed that by changing the immediate positioning context to relative we could contain it within the parent. I don't think this change has gone unnoticed for 3 months, so it's unclear what changed to trigger this bug. However we just need to skip positioning when the Tooltip is inactive, regardless.

artsyit commented 8 months ago

:rocket: PR was released in @artsy/palette-charts@36.3.4, @artsy/palette@37.3.4 :rocket: