search

artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
215 stars 45 forks source link

fix(theme): returns the default theme if none is provided #1367

Closed dzucconi closed 8 months ago

dzucconi commented 8 months ago

I'm not sure why I didn't think of this when I was upgrading Force.... 😞

This just makes it much easier to test: tests may not have a component wrapped with a theme provider and if you're using a component that makes use of the theme, then these will fail. 99% of the time, this doesn't matter at all. So just return the default theme if there isn't one provided.

Re: https://github.com/artsy/volt-v2/pull/1244

artsyit commented 8 months ago

:rocket: PR was released in @artsy/palette-charts@37.1.5, @artsy/palette@38.1.5 :rocket: