Closed anandaroop closed 6 months ago
Metrics to keep an eye on, over the next week or so:
https://artsy.looker.com/x/4ZZP5IYF5uldnH7rMYSw7f
And compare to the original sequence of events in January…
Going for it…
:rocket: PR was released in @artsy/palette-charts@37.7.0
, @artsy/palette@38.7.0
:rocket:
https://artsyproduct.atlassian.net/browse/ONYX-779
This reverts commit 36cfa119503edf04189062d2bc2f29d76fba9752.
The short version:
1361 was the last step in a sequence of fixes that attempted to workaround the non-
<a>
-like behavior of the navigational links in the global search dropdown in Force.The reverted PR addressed a real glitch, but at the cost of introducing a more common one that was discovered much later, so we are reverting it.
We hope to fix this more fundamentally in Palette by allowing Autocomplete to render options as
<a>
's when appropriateDemo of Safari versions 14–17 (via Browserstack, testing against local Force using a canary version of this PR) working as expected upon Autocomplete click:
https://github.com/artsy/palette/assets/140521/966c3b4e-9be2-4efe-9ff1-1cf1b18d33d1
📦 Published PR as canary version:
Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @artsy/palette-charts@37.2.0-canary.1373.30447.0 npm install @artsy/palette@38.2.0-canary.1373.30447.0 # or yarn add @artsy/palette-charts@37.2.0-canary.1373.30447.0 yarn add @artsy/palette@38.2.0-canary.1373.30447.0 ```