artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

feat(EMI-1813): TextArea character limit helper text #1379

Closed rquartararo closed 5 months ago

rquartararo commented 5 months ago

EMI-1813

@artsy/emerald-devs

This PR adds a the Character limit reached helper text to the TextArea that will show when the character limit has been reached, replacing the *required text when available.

This is enabled using the prop characterLimitHelper, however, once this gets officially added to the design system we will implement this change globally.

https://github.com/artsy/palette/assets/50849237/8f28c3dc-57e4-4123-83e3-0c3a9b187e35

dzucconi commented 5 months ago

Why the wait to enable it globally?

rquartararo commented 5 months ago

Why the wait to enable it globally?

@dzucconi This was suggested by @damassi so that we can unblock Emerald's work without causing any potential conflicts. slack thread

artsyit commented 5 months ago

:rocket: PR was released in @artsy/palette-charts@37.9.0, @artsy/palette@38.9.0 :rocket: