search

artsy / peril-settings

Artsy's peril settings
MIT License
31 stars 18 forks source link

Add PR review reminder; RFC-177 #116

Closed mdole closed 5 years ago

mdole commented 5 years ago

Ok! I think this is getting there and is ready for a review. Next steps after this gets merged is to test it out on the peril-settings repo (its functionality is currently restricted to only that repo until I can ascertain whether or not it's actually working as expected).

For full context, see RFC-177

Thanks @ashfurrow and @dblandin for all the help along the way!

peril-staging[bot] commented 5 years ago
Warnings
:warning: New rules detected, you probably need to update [this document](https://github.com/artsy/README/blob/master/culture/peril.md).

Generated by :no_entry_sign: dangerJS against e5e7be05f8cd1ff5201cdd5ce144993e973b4861

peril-staging[bot] commented 5 years ago
Warnings
:warning: New rules detected, you probably need to update [this document](https://github.com/artsy/README/blob/master/culture/peril.md).

Generated by :no_entry_sign: dangerJS against c71ed2ffda3c4ca82bdbff8082ccb72ff9c76984

peril-staging[bot] commented 5 years ago
Warnings
:warning: New rules detected, you probably need to update [this document](https://github.com/artsy/README/blob/master/culture/peril.md).

Generated by :no_entry_sign: dangerJS against a48ca51d6677fdef7ac60648d5477006c437c82f

mdole commented 5 years ago

alright @ashfurrow I think this should be ready to merge!