search

artsy / peril-settings

Artsy's peril settings
MIT License
31 stars 18 forks source link

Assignee shouldn't be required for Deploy PRs #122

Open dleve123 opened 5 years ago

dleve123 commented 5 years ago

Proposal:

Disable the Peril rule requiring that there be an assignee for deployment PRs (PRs from master -> release)

Reasoning

A deployment PR isn't an artifact that should require review - in repositories where we have PR-based deployments, we are just leveraging the CI hooks related to PRs to drive an automated deploy. So in this case, the Peril warning isn't needed, so it should be removed.

Exceptions:

I don't think there should be any?

Additional Context:

Here's an example PR demonstrating the problem: https://github.com/artsy/candela/pull/187

ashfurrow commented 5 years ago

Yeah, seems uncontroversial. Let's do it 👍