Default to `Version: Minor` version label

artsy / peril-settings

Artsy's peril settings

MIT License

31 stars 18 forks source link

Default to `Version: Minor` version label #155

Closed dblandin closed 4 years ago

dblandin commented 4 years ago

Most of our pull requests tend to include small feature updates rather than bug fixes. This updates the default version label, if one is not specified by the PR author, from Version: Patch (usually signaling a bug fix) to Version: Minor (usually signaling new features or enhancements).

Slack: https://artsy.slack.com/archives/C2TQ4PT8R/p1589835915176200

dblandin commented 4 years ago

@zephraph It looks like we have our labels defined here: https://github.com/artsy/auto-config/blob/b8e275b7fa20ba613492e718d20df4ae7f43190f/package.json#L13-L48

Does this mean that we can remove the code that creates labels via the GitHub API in this task?

zephraph commented 4 years ago

@dblandin I don't think auto creates those automatically out of the box. While we could always run auto create-labels, but that might require setup elsewhere.

dblandin commented 4 years ago

Unfortunately I don't think most people think about these labels when merging a PR

If that's truly the case, we might consider not assigning a default label and having Danger/Peril prompt the PR author to set one explicitly.

Might be less useful if we end up moving artsy/reaction into artsy/force but I've found that PRs tagged appropriately are useful when reviewing a Deploy PR.