Closed dleve123 closed 4 years ago
Problem
In https://github.com/artsy/metaphysics/pull/2437/commits/39b06c0a955a7a036312003ac0765658497852ef, we updated our MP tooling so that we compare against the Force GraphQL schema, instead of Reaction's, now that Reaction has been merged into Force.
As such, recent MP PRs have had breaking building due to peril-artsy not being able to find compareReactionSchema, for example: https://github.com/artsy/metaphysics/pull/2438
Moreover, whatever value that this comparison script is providing is minimized as the script wasn't running.
Solution
Yep! Looks good 👍
zephraph
commented
4 years ago zephraph
commented
4 years ago
Problem
In https://github.com/artsy/metaphysics/pull/2437/commits/39b06c0a955a7a036312003ac0765658497852ef, we updated our MP tooling so that we compare against the Force GraphQL schema, instead of Reaction's, now that Reaction has been merged into Force.
As such, recent MP PRs have had breaking building due to peril-artsy not being able to find compareReactionSchema, for example: https://github.com/artsy/metaphysics/pull/2438
Moreover, whatever value that this comparison script is providing is minimized as the script wasn't running.
Solution