Getting infinite loading spinner on some articles

artsy / positron

Positron is Artsy Writer or the editorial tool and API for Artsy.

MIT License

85 stars 40 forks source link

Getting infinite loading spinner on some articles #1151

Open kanaabe opened 7 years ago

kanaabe commented 7 years ago

Getting a loading spinner on some editorial articles (I think older ones) saying reaction-force is missing

kanaabe commented 7 years ago

Really weird, but it looks like the artwork -> image_collection conversion is being blocked by some ad blockers. For example, https://d32dm0rphc51dk.cloudfront.net/AD_O6RQGjTZbDqV2JpHQ3g/larger.jpg this image is a valid image, but it's erroring with net::ERR_BLOCKED_BY_CLIENT. Same issue doesn't occur in an incognito browser, however.

Ignore the reaction-force error above..

kanaabe commented 7 years ago

This is actually hilarious -- Ad blocker plus's reason for blocking the image is bc the url contains .net/ad_ 🙄

eessex commented 7 years ago

So weird, I wonder how many of our filenames have this problem -- I wonder if there's a straightforward way to reprocess these in cloudfront.

kanaabe commented 7 years ago

I'm working on some error handling to mitigate the loading problem, but it doesn't seem to be an issue that comes up often. It'd be probably not be worthwhile to test every image against the EasyList 💀