search

artsy / positron

Positron is Artsy Writer or the editorial tool and API for Artsy.
MIT License
85 stars 42 forks source link

fix: use es6 import for save.coffee functions #3111

Closed mc-jones closed 1 year ago

mc-jones commented 1 year ago

This PR resolves the generateKeywords type error blocking CI by using ES6 import syntax instead of require.

It's not totally clear what caused this to suddenly break, as this is older code, but seems OK for now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3111 (b2fa9d6) into main (c0348db) will increase coverage by 0.5%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3111     +/-   ##
=======================================
+ Coverage   83.0%   83.6%   +0.5%     
=======================================
  Files        198     197      -1     
  Lines       5420    5375     -45     
  Branches     989     976     -13     
=======================================
- Hits        4504    4496      -8     
+ Misses       663     626     -37     
  Partials     253     253