Closed egdbear closed 8 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
6393e4e
) 83.6% compared to head (7876fd3
) 83.6%.
Suggested migration: This will block Positron's existing users from certain actions unless we grant them the new role prior to releasing this. We can query recent log-ins (like here) to identify the accounts that should be considered for the new role, then confirm with the Editorial folks.
I was wondering where to add those emails. I will add the account emails to the ticket.
Potential bug: Some of these admin-only cases may depend on back-end APIs that also require the admin role, like to search users. Does Gravity need changes to support the new role there?
/search
- under the hood is calling an ES endpoint. I believe we don't have any authorization set for that?.
/api/v1/me
- is being called when using the /users
endpoint.
Possibly because M1, asdf and outdated SSL (due to old ruby versions) I couldn't run the app.
To run locally connected to staging I had to update the scripts/start.sh
# !/usr/bin/bash
set -e -x
forever -c 'node --max_old_space_size=1024 --no-experimental-fetch --openssl-legacy-provider' ./src/index.js --colors
I haven't followed the latest changes closely enough to know when this can be merged, so I'll approve and add you to assignees. Let me know if you can use more feedback!
🙏
This pull request removes the 'team' and 'admin' roles and replaces them with the 'editorial' role.
DIA-230
Gravity PR for enabling the Editorial roles
@artsy/diamond-devs