artsy / positron

Positron is Artsy Writer or the editorial tool and API for Artsy.
MIT License
85 stars 42 forks source link

feat: k8s 1.21 deprecations #3144

Closed artsyjian closed 4 months ago

artsyjian commented 4 months ago

feat: k8s 1.21 deprecations

artsyjian commented 4 months ago

build failed with:

positron_1                |   1) Article #destroy removes the article from elasticsearch:
positron_1                |      Uncaught TypeError: Cannot read property 'hits' of undefined
positron_1                |       at src/api/apps/articles/test/model/index/index.spec.ts:158:31
positron_1                |       at respond (node_modules/elasticsearch/src/lib/transport.js:308:9)
positron_1                |       at checkRespForFailure (node_modules/elasticsearch/src/lib/transport.js:248:7)
positron_1                |       at HttpConnector.<anonymous> (node_modules/elasticsearch/src/lib/connectors/http.js:164:7)
positron_1                |       at IncomingMessage.wrapper (node_modules/elasticsearch/node_modules/lodash/index.js:3095:19)
positron_1                |       at IncomingMessage.EventEmitter.emit (domain.js:483:12)
positron_1                |       at endReadableNT (_stream_readable.js:1241:12)
positron_1                |       at processTicksAndRejections (internal/process/task_queues.js:84:21)
joeyAghion commented 4 months ago

Not sure what's going on here...

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.0%. Comparing base (b746ad4) to head (ff54e2c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3144 +/- ## ======================================= - Coverage 83.5% 83.0% -0.5% ======================================= Files 197 197 Lines 5388 5410 +22 Branches 978 985 +7 ======================================= - Hits 4500 4494 -6 - Misses 635 662 +27 - Partials 253 254 +1 ```
artsyjian commented 4 months ago

test passed upon re-run of the build. it's a flake.