search

artsy / rosalind

Admin app for batch operations on genomes
https://artsy.github.io/blog/2019/05/09/rosalind/
MIT License
5 stars 8 forks source link

chore: use circleci bundle-github context #737

Closed ovasdi closed 1 year ago

ovasdi commented 1 year ago

Solves https://artsyproduct.atlassian.net/browse/PHIRE-80

Read BUNDLE_GITHUB__COM from CircleCI context when building an image in CI.

rosalind project CI pipleine uses hokusai orb jobs for executing tests and pushing to the image repository. Both jobs perform a docker build and thus depend on that variable as declared in the Dockerfile. bundle-github context is therefore added in two places: test and push jobs.

Also, move contexts' into jobs.

Migration

  1. unset BUNDLE_GITHUB__COM in rosalind CircleCI Project Environment Variables
  2. merge PR
ovasdi commented 1 year ago

There appears to be a flaky test situation. It passed while I was trying to debug so FYI.