search

artsy / rosalind

Admin app for batch operations on genomes
https://artsy.github.io/blog/2019/05/09/rosalind/
MIT License
5 stars 8 forks source link

chore: fix chrome 114 install #792

Closed ovasdi closed 3 months ago

ovasdi commented 3 months ago

https://artsyproduct.atlassian.net/browse/PHIRE-1001

Similarly as https://github.com/artsy/ohm/pull/951/files, chrome 114, which is required by pinned selenium-webdriver version, is no longer hosted and so this switched to self hosted version until codebase is on ruby >=3.

ovasdi commented 3 months ago

Will look into the error next week. Looks like this line blew up.

brainbicycle commented 3 months ago

Will look into the error next week. Looks like this line blew up.

If that is just printing version probably fine to just remove since the pipeline is broken otherwise

ovasdi commented 3 months ago

Will look into the error next week. Looks like this line blew up.

If that is just printing version probably fine to just remove since the pipeline is broken otherwise

@brainbicycle I wanted to propose making this change https://github.com/artsy/rosalind/pull/792/commits/c8cc1dfdc24eedc5f8446f154d1ab8da7a8f54ee. This way google-chrome is in PATH. I figured this may be closer to how google-chrome get setup and even thought we install it in a custom location, it'll be available to run without specifying full path.

brainbicycle commented 3 months ago

Will look into the error next week. Looks like this line blew up.

If that is just printing version probably fine to just remove since the pipeline is broken otherwise

@brainbicycle I wanted to propose making this change c8cc1df. This way google-chrome is in PATH. I figured this may be closer to how google-chrome get setup and even thought we install it in a custom location, it'll be available to run without specifying full path.

sounds reasonable!