artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

500 hotglue-bundle-1.js breaking client-side javascript #100

Closed kanaabe closed 7 years ago

kanaabe commented 7 years ago

It looks like since this commit we're no longer getting client-side js working. I haven't dug into the details but the server-side error we kept seeing: Error: Cannot find module './lib-cov' is also related to this.

orta commented 7 years ago

Full log:

screen shot 2017-08-21 at 16 42 28

orta commented 7 years ago

Looking more like https://github.com/artsy/team-navigator/commit/a0cc52768b8d554f181ef282975e533e8238b88a - just went through those commits and clicked around, this is where I started getting them

orta commented 7 years ago

Resetting these three files back a commit stops it:

 ~/d/p/a/j/s/team-navigator  ➦ a0cc527 ~$  git s                                                                                                       Mon 21 Aug 17:21:53 2017
HEAD detached at a0cc527
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

    modified:   app/controllers/index.js
    modified:   app/router.js
    modified:   app/views/sidebar/locations-teams.js
orta commented 7 years ago

Stumped, ran out of time.

orta commented 7 years ago

Fixed 👍