search

artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

Open external links in new tab #125

Closed dblandin closed 5 years ago

dblandin commented 5 years ago

Open any external links in a new tab and additionally render an icon on such links.

Whether links should open in a new tab can be a controversial topic, but I've often clicked around the Team Navigator wishing that external links would open in a new tab.

I think that behavior is common enough to support here. For example, the social links at the bottom of artsy.net open in a new tab. To communicate the behavior, I've additionally added a small icon next to external links to signal that the link is external to the Team Navigator and will open in a new tab.

screen shot 2018-10-25 at 3 04 49 pm screen shot 2018-10-25 at 3 05 04 pm

zephraph commented 5 years ago

Awesome, thanks @dblandin! As a side note @orta, we should get some CI setup for this repo.