artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

Profiles for Carter and Sebastian display duplicate reportees #126

Open dleve123 opened 6 years ago

dleve123 commented 6 years ago

Carter's and Sebastian's profiles show duplicate names for some of their reportees. I haven't looked at the code, but by observing the behavior, it seems like the duplicated reportees are reportees that themselves have reportees (for example, db is duplicated, but tim isn't).

dleve123 commented 6 years ago

Follow up from @KatherineO on Slack:

Thanks, @dleve123! people on the leadership team (like dB) are actually listed in the team navigator twice! it was our workaround to clarify who was on the leadership team since there's the leadership group with artsy executives (https://team.artsy.net/org/the-leadership-team) and then the leadership team...so it's confusing

dblandin commented 6 years ago

I noticed this duplication in the Google sheet as well.

orta commented 6 years ago

We could unique the reportees by email in the sidebar then, as it looks like it's there for a legit reason

dleve123 commented 6 years ago

We could unique the reportees by email in the sidebar then, as it looks like it's there for a legit reason

From Katherine's Slack comment, it seems like uniquing the sidebar wouldn't be great b/c the duplication is actually a heuristic used to indicate that someone is in the leadership team and org.

I proposed the following in Slack (slightly modified, here):

got it --- hmm, I wonder if it would make sense to:

1. Display the Organization of an individual (in addition to their team)
2. Rename the Leadership Team Team to something else

just food for thought - I'm sure the name of that team would have to be workshopped haha, but for the sake of org clarity, it could be useful to have a different name.