artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

@craigspaeth - add top nav / letter filterer #62

Closed broskoski closed 8 years ago

orta commented 8 years ago

hah, everyone's getting in on the team-nav train

craigspaeth commented 8 years ago

Got some standard linter warnings, plz run npm run lint. Some testing/linting best practices are also explained in the README.md.

standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/team-navigator/app/views/index.js:7:23: 'topnav' is defined but never used.
  /home/runner/team-navigator/app/views/topnav.js:7:20: Strings must use singlequote.
  /home/runner/team-navigator/app/views/topnav.js:7:55: Strings must use singlequote.
craigspaeth commented 8 years ago

Otherwise looks good! I challenge you to write some tests 😁 but feel free to merge when 💚