search

artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

Add link to reports to member #67

Closed OLI9292 closed 8 years ago

OLI9292 commented 8 years ago

Fixes an issue of displaying "Reports to" for members who don't have that field, and adds a link to the "Reports to" member that brings up their sidebar view.

The href is unfortunately a lil verbose, because state.get('member').reportsTo returns a string, not the member object. Also, I wonder if there's a way to use a single div instead of the doubly nested thing I ended up with...

craigspaeth commented 8 years ago

Looks good! Thanks for the PR :) I challenge you to write tests for the next one.