Open dylanfareed opened 10 years ago
It may actually be that we want to change this up somewhat markup-wise so that the close button and title typically stay visible in the top of the modal and that the thing that ends up scrolling is the "content"
Yes. That totally makes sense. Structure-wise, the markup should consist of pre-defined "sections", like header, close button, content, and even a footer, and the header and the close button should be static.
(°̥̥̥̥̥̥̥̥ᴗ°̥̥̥̥̥̥̥̥ ) << happy agreement cry
Wait, is it only me or they are actual overflow tears!?
https://github.com/artsy/watt/blob/master/vendor/assets/stylesheets/watt/_modals.css.scss.erb#L7
Bonus points for swapping out the image asset close button for joule's
icon-close
buttonhttps://github.com/artsy/watt/blob/master/vendor/assets/stylesheets/watt/_modals.css.scss.erb#L35
http://artsy.github.io/joule/output/demo.html