artsy / watt

Watt is a shared js/css/img asset library for Artsy Rails apps.
https://github.com/artsy/watt
MIT License
0 stars 0 forks source link

Add horizontal padding to fancybox inner so that overflow scroll bars have some breathing room #105

Open dylanfareed opened 10 years ago

dylanfareed commented 10 years ago

https://github.com/artsy/watt/blob/master/vendor/assets/stylesheets/watt/_modals.css.scss.erb#L7

image

Bonus points for swapping out the image asset close button for joule's icon-close button

https://github.com/artsy/watt/blob/master/vendor/assets/stylesheets/watt/_modals.css.scss.erb#L35

http://artsy.github.io/joule/output/demo.html

dylanfareed commented 10 years ago

It may actually be that we want to change this up somewhat markup-wise so that the close button and title typically stay visible in the top of the modal and that the thing that ends up scrolling is the "content"

starsirius commented 10 years ago

Yes. That totally makes sense. Structure-wise, the markup should consist of pre-defined "sections", like header, close button, content, and even a footer, and the header and the close button should be static.

gib commented 10 years ago

(°̥̥̥̥̥̥̥̥ᴗ°̥̥̥̥̥̥̥̥ ) << happy agreement cry

starsirius commented 10 years ago

Wait, is it only me or they are actual overflow tears!?