artsy / watt

Watt is a shared js/css/img asset library for Artsy Rails apps.
https://github.com/artsy/watt
MIT License
0 stars 1 forks source link

fix: upgrade middleman-s3_sync to fix deploys #361

Closed ovasdi closed 2 years ago

ovasdi commented 2 years ago

This PR fixes (currently broken) deploy job that is throwing the following error:

bundler: failed to load command: middleman (/root/project/vendor/bundle/ruby/2.6.0/bin/middleman)
LoadError: cannot load such file -- xmlrpc/client

In ruby v2.4.0 the xmlrpc lib was removed from stdlib and extracted into a gem. This adds that gem as a dependency and also updates the .ruby-version to match the version used in CI config.

ovasdi commented 2 years ago

@joeyAghion Thanks to your comment I took a closer look and noticed that:

I decided to:

joeyAghion commented 2 years ago

Nice--that's even better.