artsyfriedchicken / EdgyArc-fr

Firefox Userchrome and sidebery style
Mozilla Public License 2.0
575 stars 13 forks source link

Broken on Windows #13

Closed phougt closed 5 months ago

phougt commented 5 months ago

Describe the bug When I tried out the beta7 and beta7.1, my Firefox Dev Edition just broke. I couldn't move the browser windows or interact with any button on the toolbar.

To Reproduce Steps to reproduce the behavior:

  1. Copy-Paste the contents into the chrome folder

Expected behavior I expected everything to be working normally, clickable.

Desktop (please complete the following information):

Additional context Everything froze except the content of the websites itself.

artsyfriedchicken commented 5 months ago

was this behaviour present in the beta 6 release?

phougt commented 5 months ago

Hello dear, no, it doesn't present in the beta 6 release.

artsyfriedchicken commented 5 months ago

Righto, ill figure out a fix asap!

phougt commented 5 months ago

Hello dear, I tried it again. The toolbar buttons work fine, but the browser window is bit unresponsive. I couldn't make it snap, sharp corner, big white line around the border. Here are some screenshot: NVIDIA_Share_q9TsIIZzCn firefox_Zq0kV4IkJR

artsyfriedchicken commented 5 months ago

That is VERY weird. do you have any other mods applied to userchrome.css?

phougt commented 5 months ago

I did not applied anything. I will try to re-paste the contents in chrome folder again.

phougt commented 5 months ago

I tried it again, but the problem still persist.

artsyfriedchicken commented 5 months ago

Cannot replicate bug. Please make sure youre on https://github.com/artsyfriedchicken/EdgyArc-fr/releases/tag/v1.0.0-beta.7.1

and have the following flags enabled in about:config uc.tweak.hide-tabs-bar uc.tweak.hide-forward-button uc.tweak.rounded-corners uc.tweak.floating-tabs uc.tweak.af.not-translucent

as well as these ones : toolkit.legacyUserProfileCustomizations.stylesheets svg.context-properties.content.enabled layout.css.color-mix.enabled layout.css.light-dark.enabled layout.css.has-selector.enabled

this is what it looks on my test windows system running win11 pro and ff 124. perhaps its a bug introduced in 125 betas? Im not going to try and support ff beta releases, thats just utterly exhausting.

WhatsApp Image 2024-03-26 at 12 14 48 AM

phougt commented 5 months ago

Thank you for your hard work. I really appreciate your help.

phougt commented 5 months ago

I will try it on the ff 124, and see if the problem still persist.

phougt commented 5 months ago

Unfortunately, the problem still present. I think the problem is my machine or user error. Thank you again for your help.

artsyfriedchicken commented 5 months ago

This bug is so fucking odd and out of nowhere its its an earworm for me lmao!

I'm deffo gonna keep an eye out for the bug and see if i can replicate it!

In the meantime, if you have some free time on your hands and feel so inclined, id love it if you could try selecting the white border using the element picker in browser toolbox and sending me a screenshot or details of which element is causing the border!! So far, the only thing ive added a white border to is #main-window::before, but i can see the #main-window::before border being drawn INSIDE the fat white border in your screenshot as well.

TickyTacky999 commented 5 months ago

I had the exact same issue as you, I've tried it on ff 124 and the latest beta build

artsyfriedchicken commented 5 months ago

Can either one of you please open the browser toolbox in firefox, use the element inspector to select the white border and tell me what element it is? I can't seem to replicate the bug on my vm

TickyTacky999 commented 5 months ago

Can either one of you please open the browser toolbox in firefox, use the element inspector to select the white border and tell me what element it is? I can't seem to replicate the bug on my vm

Sure thing! I am not at home yet due to work. When I get home I will do it!

TickyTacky999 commented 5 months ago

I am pretty dumb when it comes to all this stuff. However, I tried doing what you asked. But it doesn't seem like I can inspect that border at all. (Or I might be doing something wrong).

I used the element inspector, hovered over it but nothing shows up. If I did something wrong feel free to explain the correct steps so I can do it for you..

I did manage to replicate it tho.

firefox_tpRiH75TAO

image

artsyfriedchicken commented 5 months ago

I am pretty dumb when it comes to all this stuff. However, I tried doing what you asked. But it doesn't seem like I can inspect that border at all. (Or I might be doing something wrong).

I used the element inspector, hovered over it but nothing shows up. If I did something wrong feel free to explain the correct steps so I can do it for you..

I did manage to replicate it tho.

firefox_tpRiH75TAO

image

Oh that is BEYOND bizzare lmao

can you pull my latest changes and try it on a fresh new profile please?

Screen Shot 2024-03-27 at 7 42 01 PM This is how it looks for me on windows atm. And im pretty fucking stumped lmao

TickyTacky999 commented 5 months ago

I used Revo Uninstaller to wipe Firefox and all it's data, reinstalled it. Then I pulled the new changes you made, set it up and voila! Looks like it's fixed!

image

phougt commented 5 months ago

Wow, I will try that as well.

TickyTacky999 commented 5 months ago

The only thingy I have is: image Is this normal?

artsyfriedchicken commented 5 months ago

The only thingy I have is: image Is this normal?

no it is not. but its a known bug. My eyes hurt rn, im gonna take a crack at it in a few hours.

PS - please do let me know if you face the "window randomly shrinks to 1px speck on the screen" bug - it is most definitely a bug, and not your browser being hacked. XD

also, PLEASE make sure you have uc.tweak.af.not-translucent enabled!!! windows REALLY doesnt seem to like it when i declare firefox to have a transparent bg on :root

TickyTacky999 commented 5 months ago

The only thingy I have is: image Is this normal?

no it is not. but its a known bug. My eyes hurt rn, im gonna take a crack at it in a few hours.

PS - please do let me know if you face the "window randomly shrinks to 1px speck on the screen" bug - it is most definitely a bug, and not your browser being hacked. XD

also, PLEASE make sure you have uc.tweak.af.not-translucent enabled!!! windows REALLY doesnt seem to like it when i declare firefox to have a transparent bg on :root

uc.tweak.af.not-translucent is disabled. No worries, hope you have a good rest and thank you a lot for your work!

phougt commented 5 months ago

I just tried version 8. It works flawlessly. Thank you for your hard work. image

artsyfriedchicken commented 5 months ago

BTW, GUYS, try sticking the reload button on the RIGHT of the addressbar, i added some css to make it sit inside the urlbar when you do that!

phougt commented 5 months ago

btw, do you mind sharing with us about how you fix the buggy window with thick white border?

phougt commented 5 months ago

i added some css to make it sit inside the urlbar when you do that!

image

Nice

artsyfriedchicken commented 5 months ago

btw, do you mind sharing with us about how you fix the buggy window with thick white border?

I would if i fucking could LMAO

i just faffed around with the code a bit and it fixed itself man. literally couldnt replicate the bug on my end. at all. even once. XD

artsyfriedchicken commented 5 months ago

The only changes that i made were