search

artsyfriedchicken / EdgyArc-fr

Firefox Userchrome and sidebery style
Mozilla Public License 2.0
575 stars 13 forks source link

UI text color dull/muted/pale (Linux) #14

Closed alixyz-1 closed 5 months ago

alixyz-1 commented 5 months ago

Text colour on the browser UI is dull/muted/pale. Text should be more vibrant and readable? Unsure if this is just an issue on Linux or is universal - if an intended feature, then a toggle/option would be great :)

Screenshots below: Different colours from Adaptive Tab Bar Colour show that the text is kind of hard to read and appears "washed out". Screenshot_20240324_195055 Screenshot_20240324_195112 Screenshot_20240324_195019

Screenshot: Worse when window is unfocused. Screenshot_20240324_200313

artsyfriedchicken commented 5 months ago

couple of things

  1. uc.tweak.af.not-translucent was introduced in beta 7.1. please make sure you have the latest main.css and not-translucent.css
  2. Unfortunately the washed out colours are an unfortunate sideeffect of trying to get translucency working in macos. the not-translucent flag should help mitigate it A BIT
  3. adaptive tab colour addon sometimes picks THE most obnoxious colours lmao. im trying to figure out a solution to overlay it with a light/dark colour to make it more paletable atm!
  4. yes i have the sidebar opacity go down for unfocused windows as that the default macos behaviour. if that is not something that goes with linux based window management lemme know and i can fix that in a min :)
alixyz-1 commented 5 months ago

Hi, thank you very much for your response! Thanks for the info about the newer release - it looks like github is still showing beta 7 as the latest version for some reason: image

Regarding the opacity for unfocused windows, a toggle would be great if that's something you have time to work on - I personally don't like how dark it gets.

I really love the look of this project - I would be grateful if you had any pointers that might help me hack away at the css to make the UI text colour appear better for me - perhaps anything that's related to what you mentioned about macos translucency requirements, and if i have any luck I'll feed it back to you in case you find it of any use :)

Thanks again!

artsyfriedchicken commented 5 months ago

Yeah, sure, i can put in a toggle for the dimming in my next commit later today! Just a lil something to force the toolbar and sidebar to always have 100% opacity!

The text colour on the other hand SHOULD be fixed by enabling the non-translucent flag - that literally hard sets the opacity of the sidebar to 100%, and the font colour is set to light-dark(black, white)

As for your last point, im actually working on simplifying and streamlining the code atm, hopefully itll be pretty self-explanatory once its all cleaned up and commented!!

alixyz-1 commented 5 months ago

Hi thank you so much for that - I've just tried the latest commit and tried setting the uc.tweak.no-dimming to true and while it still dims the opacity of the text quite a bit when the window is not focused, the text on the active window is now perfectly readable and looks great!

artsyfriedchicken commented 5 months ago

Thats odd, it shouldnt be dimming the sidebar on inactive windows... Please do try the new update i just pushed? fingers crossed that solves it lmao

alixyz-1 commented 5 months ago

Hi there, I just tried out the beta.8 release and unfortunately the issue remains. I tried installing on a fresh firefox profile and it still happens. Below is a recording of it happening in case it helps: Screencast_20240327_170952-2.webm The tab sidebar opacity increases on sidebar hover and when clicked/focused the top bar opacity increases too. Thanks for your attention to this :)

artsyfriedchicken commented 5 months ago

oh this helps immensely!! i THINK i know what is tripping it up!!