search

artsyfriedchicken / EdgyArc-fr

Firefox Userchrome and sidebery style
Mozilla Public License 2.0
575 stars 13 forks source link

I can't reproduce the theme exactly like you have it on the pictures #6

Closed ghost closed 5 months ago

ghost commented 6 months ago

I'm unable to make the theme look exactly like in the pictures. Could you please make a video tutorial alongside another video where you show how the theme looks and how to make it work?

ghost commented 6 months ago
Screenshot 2024-02-25 at 8 19 01 PM

Nice, so I think i finally got some of the theme to work. Here's a screenshot of how it looks like. Please let me know if I'm missing anything. I noticed a small bug bottom left it's not showing the whole thing. Also, when I have a tab that has sounds, the sound icon will be super glitchy and move when I hover on the tab that's playing sound. Other than that let me know if I did everything correctly

Marshall2HD commented 6 months ago

Did you have an issue where Sideberry when collapsed looked a bit off like this? image

~~When enabling translucency it also looks like this: https://i.imgur.com/tbYjEgt.png~~ nvm, it seems translucent is for MacOS only.

ghost commented 6 months ago

I found another bug - when you have about 20 tabs open and say you click on the 20th tab, or the first tab, it will be glitchy and sort of scroll for you. Difficult to explain over text, but basically switching back and forth between tabs is not smooth.

Also, when you collapse the sidebeery sidebar to only keep icons of tabs, hovering over them brings the whole sidebar again, instead of just letting you click the icons. The animation is also not smooth.

This theme is great, just a few bugs to be fixed, but a lot of potential overall.

artsyfriedchicken commented 6 months ago

Did you have an issue where Sideberry when collapsed looked a bit off like this? image

~When enabling translucency it also looks like this: https://i.imgur.com/tbYjEgt.png~ nvm, it seems translucent is for MacOS only.

Unfortunately windows development will only get underway once i have a couple of people willing to beta test this out in windows, as i currently dont have access to a windows machine.

artsyfriedchicken commented 6 months ago

I found another bug - when you have about 20 tabs open and say you click on the 20th tab, or the first tab, it will be glitchy and sort of scroll for you. Difficult to explain over text, but basically switching back and forth between tabs is not smooth.

Also, when you collapse the sidebeery sidebar to only keep icons of tabs, hovering over them brings the whole sidebar again, instead of just letting you click the icons. The animation is also not smooth.

This theme is great, just a few bugs to be fixed, but a lot of potential overall.

The newest build v1.0.0-beta.5 has a ton of the theme rewritten. Please let me know if it solves your issues.

Also, the sidebar auto-expanding on hover is a feature, not a bug lol. Im open to adding a preference you can use to stop the auto expand though!

ghost commented 6 months ago

I found another bug - when you have about 20 tabs open and say you click on the 20th tab, or the first tab, it will be glitchy and sort of scroll for you. Difficult to explain over text, but basically switching back and forth between tabs is not smooth. Also, when you collapse the sidebeery sidebar to only keep icons of tabs, hovering over them brings the whole sidebar again, instead of just letting you click the icons. The animation is also not smooth. This theme is great, just a few bugs to be fixed, but a lot of potential overall.

The newest build v1.0.0-beta.5 has a ton of the theme rewritten. Please let me know if it solves your issues.

Also, the sidebar auto-expanding on hover is a feature, not a bug lol. Im open to adding a preference you can use to stop the auto expand though!

Appreciate the response. I haven't noticed any improvements when it comes to smoothness when going back and forth between tabs (when you have many of them opened), however i'd like to make a few suggestions:

artsyfriedchicken commented 6 months ago

I found another bug - when you have about 20 tabs open and say you click on the 20th tab, or the first tab, it will be glitchy and sort of scroll for you. Difficult to explain over text, but basically switching back and forth between tabs is not smooth. Also, when you collapse the sidebeery sidebar to only keep icons of tabs, hovering over them brings the whole sidebar again, instead of just letting you click the icons. The animation is also not smooth. This theme is great, just a few bugs to be fixed, but a lot of potential overall.

The newest build v1.0.0-beta.5 has a ton of the theme rewritten. Please let me know if it solves your issues. Also, the sidebar auto-expanding on hover is a feature, not a bug lol. Im open to adding a preference you can use to stop the auto expand though!

Appreciate the response. I haven't noticed any improvements when it comes to smoothness when going back and forth between tabs (when you have many of them opened), however i'd like to make a few suggestions:

* Bring the URL on the sidebar like Arc

* Tweak the UI on the sidebar (specifically the tabs) to look more like macOS/Arc

sorry, im not really interested in making this an arc clone. I'm just making something i would personally like to use. feel free to make the changes yourself though, thats the beauty of open source!!

ghost commented 5 months ago

I found another bug - when you have about 20 tabs open and say you click on the 20th tab, or the first tab, it will be glitchy and sort of scroll for you. Difficult to explain over text, but basically switching back and forth between tabs is not smooth. Also, when you collapse the sidebeery sidebar to only keep icons of tabs, hovering over them brings the whole sidebar again, instead of just letting you click the icons. The animation is also not smooth. This theme is great, just a few bugs to be fixed, but a lot of potential overall.

The newest build v1.0.0-beta.5 has a ton of the theme rewritten. Please let me know if it solves your issues. Also, the sidebar auto-expanding on hover is a feature, not a bug lol. Im open to adding a preference you can use to stop the auto expand though!

Appreciate the response. I haven't noticed any improvements when it comes to smoothness when going back and forth between tabs (when you have many of them opened), however i'd like to make a few suggestions:

* Bring the URL on the sidebar like Arc

* Tweak the UI on the sidebar (specifically the tabs) to look more like macOS/Arc

sorry, im not really interested in making this an arc clone. I'm just making something i would personally like to use. feel free to make the changes yourself though, thats the beauty of open source!!

Thanks for the idea, I'm extremely busy these days, but I'll see if I can find some time to make the tweaks myself. You did give me a very good baseline here.

jo-adithya commented 5 months ago

Hey @artsyfriedchicken, really great stuff you have here 😁 Thanks for sharing this all!

I have a question on tweaking this a bit. Do you know how to increase the transparency of the toolbar and the sidebar? I tried changing the background color alpha but didn't quite make it. I have no idea how to change the alpha for the sidebar as well. Here is my current state:

Screenshot 2024-03-21 at 7 23 59 PM

The sidebar color is the only one that is not transparent. Do you know how to fix this? Any help would be very much appreciated 😁 Thanks!

artsyfriedchicken commented 5 months ago

The sidebar unfortunately can NOT be transparent. lmao.

This is essentially why the code for this is SO fucking annoying XD The sidebar is a separate process from the browser ui. and as such, has a white background behind it. that cannot be changed or removed. The way i simulate the transparency is changing the opacity for #sidebar-box and #sidebar.