feat: templatize values

arttor / helmify

Creates Helm chart from Kubernetes yaml

MIT License

1.48k stars 136 forks source link

Open vbehar opened 1 year ago

vbehar commented 1 year ago

instead of using raw values - such as {{ .Values.some.thing }} - let's wrap them with the tpl function.

the previous example would then be rendered as {{ tpl (.Values.some.thing) $ }}

So that we can reference other values from inside our values for example.

arttor commented 1 year ago

Hi @vbehar! Thank you for your contribution. The proposal looks very interesting but i see several potential problems:

the change is quite big and it is better to hide it under a feature flag to not surprise users after upgrading to a new version
overusing tpl function may lead to performance issues see
in the PR, not all template values are wrapped into tpl. How to decide which one should be wrapped?