arttor / helmify

Creates Helm chart from Kubernetes yaml
MIT License
1.48k stars 137 forks source link

Chart.Appversion not as a default usable since image.tag set in values.yaml #15

Open batistein opened 2 years ago

batistein commented 2 years ago

Thank you for this amazing project.

When generating the charts, the image tag is also set in values.yaml. In the deployment itself, the default is set correctly (.Chart.Appversion) , but it can not be used by default since the image tag is set in the values.yaml. Especially with the combination of helmify with helmfile where values are only overwritten this is a little bit disturbing.

arttor commented 2 years ago

Thank you for the feedback!

Totally agree that Appversion should be a default value for the image tag of the main container. But it is difficult to identify the main container if there are several sidecars in a pod.

I was thinking that people will use helmify to generate boilerplate and will do some polishing afterward. In this case, it is better to have all stuff in values.yaml, and users will remove redundant params.

I can see several options:

What do you think?

giautm commented 1 year ago

Hello @arttor, I running into the same issue. We need to remove the tag from image, but there is no option to do that.

I prefer to the option always remove image tag from values.yaml, but we can avoid BC with --no-image-tag in the CLI