arttor / helmify

Creates Helm chart from Kubernetes yaml
MIT License
1.48k stars 136 forks source link

Optional secrets #152

Open manherna opened 1 month ago

manherna commented 1 month ago

Hi! I wanted to check if there is a way to enable optional secrets for helmify. Suppose a user could either provide a value for the helm chart create a secret or leave it empty, because they have other means to create it (something like an externalSecrets operator). Would this be doable? With something like a tag in the kustomize or similar?

I am open to implementing it if needed. Thanks, Manuel

arttor commented 3 weeks ago

hi, i think that it is a good idea but i don't know how it can be implemented. Pass secret name in flag? What name for the secret should be used in values.yaml? is multiple secrets should be supported?

Can you please provide a short example how it will look like?

  1. incoming yaml (deployment?) with several secrets
  2. helmify call with flags to make some of the secrets external
  3. resulted values.yaml and template with extenal secrets
manherna commented 3 weeks ago

Hi Artem, I was thinking something like the secret name in flag or an specific annotation for optional secrets. What do you think? I will try and provide a solution.

Thanks! Manuel

El dom, 27 oct 2024 a las 13:59, Artem @.***>) escribió:

hi, i think that it is a good idea but i don't know how it can be implemented. Pass secret name in flag? What name for the secret should be used in values.yaml? is multiple secrets should be supported?

Can you please provide a short example how it will look like?

  1. incoming yaml (deployment?) with several secrets
  2. helmify call with flags to make some of the secrets external
  3. resulted values.yaml and template with extenal secrets

— Reply to this email directly, view it on GitHub https://github.com/arttor/helmify/issues/152#issuecomment-2440006230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO6DGTPJDI7KGZE5NNOCNTZ5TISFAVCNFSM6AAAAABQKHCZECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGAYDMMRTGA . You are receiving this because you authored the thread.Message ID: @.***>

arttor commented 2 weeks ago

secret name in flag - sound good