search

arttor / helmify

Creates Helm chart from Kubernetes yaml
MIT License
1.48k stars 137 forks source link

Fix pod annotation, cert-name and add support for MutatingWebhookConfiguration #21

Closed yxd-ym closed 2 years ago

yxd-ym commented 2 years ago
  1. Preserve the line break before annotation.
  2. Trim the prefix of cert-name properly.
  3. Add support for MutatingWebhookConfiguration.
arttor commented 2 years ago

Looks really cool! Please do not forget to add webhook manifests samples to test_data/kustomize.output or to test_data/app.yaml and regenerate examples in /examples directory by running:

cat test_data/sample-app.yaml | go run ./cmd/helmify examples/app
cat test_data/k8s-operator-kustomize.output | go run ./cmd/helmify examples/operator
yxd-ym commented 2 years ago

Looks really cool! Please do not forget to add webhook manifests samples to test_data/kustomize.output or to test_data/app.yaml and regenerate examples in /examples directory by running:

cat test_data/sample-app.yaml | go run ./cmd/helmify examples/app
cat test_data/k8s-operator-kustomize.output | go run ./cmd/helmify examples/operator

Fixed

arttor commented 2 years ago

@yxd-ym your changes are available in v0.3.6 release. Thank you for your contribution, amazing work!