search

arttor / helmify

Creates Helm chart from Kubernetes yaml
MIT License
1.48k stars 136 forks source link

Allow to specify existing imagePullSecret for podSpec #62

Closed gprossliner closed 1 year ago

gprossliner commented 1 year ago

It is considered a best practise to include an imagePullSecrets field in values.yaml so that the consumer of a helm chart can use a private registry, for which a Secret has already been created.

It would be nice if helmify checks if there is anything assigned to the ImagePullSecrets field of a PodSpec (which may be part of a Deployment, DaemonSet, ...). If this is set, helmify should continue as-is.

But if the ImagePullSecret is not set, helmify should include a imagePullSecrets in values.yaml and include it in the PodSpec, if it has been set by the user.

What do you think?

arttor commented 1 year ago

I think it is a good idea.

gprossliner commented 1 year ago

Ok. Thank you for the comment. I can make a PR for further discussion.

arttor commented 1 year ago

Please do.

gprossliner commented 1 year ago

see #63

arttor commented 1 year ago

@gprossliner thank you for your contribution. Your changes are available in v0.3.20 release.