search

arttor / helmify

Creates Helm chart from Kubernetes yaml
MIT License
1.48k stars 136 forks source link

fix: templated missing namespace metadata #78

Closed RealAnna closed 1 year ago

arttor commented 1 year ago

Thanks for your contribution but i think there may be some misunderstanding. Namespaces were removed from templates on purpose. Helm will use default namespase or set namespace from helm install -n option.

It is better to open an issue where we can discuss future changes before working on implementation.

RealAnna commented 1 year ago

Thanks for your contribution but i think there may be some misunderstanding. Namespaces were removed from templates on purpose. Helm will use default namespase or set namespace from helm install -n option.

It is better to open an issue where we can discuss future changes before working on implementation.

Hi @arttor thanks for your explanation! I did create an issue here with my motivations for namespace. About the other PRs we needed to implement a first working solution in our fork anyway, but I will make sure to generate issues for each topic linking the PRs!

arttor commented 1 year ago

@RealAnna sorry i was i little bit overwhelmed and missed the issue. I suggest not adding namespaces to templates since it is supported by helm out of the box.

RealAnna commented 1 year ago

@arttor sorry again for the spams PRs 😸 I'll make sure to document every issue