feat: add support for security context

arttor / helmify

Creates Helm chart from Kubernetes yaml

MIT License

1.48k stars 136 forks source link

feat: add support for security context #87

Closed mowies closed 1 year ago

mowies commented 1 year ago

This PR

adds the (container) security context to the chart generation

mowies commented 1 year ago

@arttor this PR should be ready for review :)

arttor commented 1 year ago

@mowies looks really nice and ready to merge. i am just thinking is there any case when chart maintainer doesn't want securityContext to be modified. In this case we should add flag and add securityContext to template only if it is enabled. what do you think?

mowies commented 1 year ago

I don't really see a use case for the CLI flag honestly.. I think if you have the security context set up, you will probably also want to show those values in the helm chart. Maybe we can leave that for now and see if users request it in the future? Should be very easy to add in the future as well.

arttor commented 1 year ago

@mowies can you please update your branch? i cannot merge pr due to conflicts

mowies commented 1 year ago

@arttor done

arttor commented 1 year ago

@mowies still can't

mowies commented 1 year ago

ok this is very weird. for me, it shows everything green with no conflicts. i will do a full rebase...

Screenshot 2023-03-15 at 10 04 43

arttor commented 1 year ago

strange, i still can't merge. can you try to rebase main?

mowies commented 1 year ago

ok, all done. seem that some examples were not fully re-generated with the last PR. I regenerated both the operator and the sample app again.

arttor commented 1 year ago

@mowies thank you! Your changes are available in v0.3.29 release