artur-ios-dev / flutter_control_pad

A control pad with a virtual joystick and buttons.
https://pub.dev/packages/control_pad
GNU General Public License v3.0
40 stars 24 forks source link

Added onTapCancel Gesture Feedback to pad_button_view #19

Closed JairajJangle closed 4 years ago

JairajJangle commented 4 years ago

While using pad_button_view on a larger screen, it is likely that user will trigger onTapCancel (larger portion of display is available for users screen pointer(finger) to slide) but this feedback is not handled in pad_button_view so the user only receives TAPDOWN gesture(corresponding to onTapDown gesture of GestureDetector widget). Therefore, added TAPCANCEL gesture to pad_button_view (corresponding to onTapCancel gesture of GestureDetector widget).

artur-ios-dev commented 4 years ago

LGTM 💯

Thank you for your contribution, merging.

Will release new version soon.