search

arturadib / agility

Javascript MVC for the "write less, do more" programmer
http://agilityjs.com
MIT License
542 stars 70 forks source link

data-bind for <input type="password"> missing #92

Closed tristanls closed 11 years ago

tristanls commented 12 years ago

The fix is here:

https://github.com/arturadib/agility/blob/master/agility.js#L579

The line is currently:

else if ($node.is('input:text, textarea')) {

It should be

else if ($node.is('input:text, input:password, textarea')) {

Just need to find some time to add tests and such to make a pull request

tristanls commented 12 years ago

could be duplicate of #82

tristanls commented 12 years ago

This probably has been caused by a fix here: fa20bdc

arturadib commented 12 years ago

That sounds right. Happy to review a PR, and it's great to see you back here :)

codeinabox commented 11 years ago

Has this been merged into the current code? I can't see this fix in 0.1.3

codeinabox commented 11 years ago

One other thing, I've noticed that Agility doesn't support the new HTML5 input types such as input:email, input:number etc.

tristanls commented 11 years ago

Fixed by #99