arturadib / strapdown

Instant and elegant Markdown documents in the browser
http://strapdownjs.com
MIT License
2.48k stars 410 forks source link

https://strapdownjs.com has a wrong certificate #92

Closed orecht closed 5 years ago

orecht commented 5 years ago

Browsing to https://strapdownjs.com give the folowing error in Firefox:

strapdownjs.com uses an invalid security certificate. The certificate is only valid for the following names: .github.com, github.com, .github.io, github.io Error code: SSL_ERROR_BAD_CERT_DOMAIN

Could you check your github pages configuration?

lazyval commented 5 years ago

@arturadib recently Github guys made it way easier to fix: https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

Can you please go and update A record? (hopefully you would not need to fix all the css and img files as well). Unfortunately, it's ain't something we can contribute ourselves.

At current state broken certificate prevents some of the sites from using strapdown.js properly. Because javascript is served from strapdownjs.com, when browser loads https page that uses strapdown, script is blocked as the mixed content.

arturadib commented 5 years ago

i've made the A record changes, it needs to propagate though.. fingers crossed. -Artur

On Fri, Oct 19, 2018 at 4:47 AM Kostya Golikov notifications@github.com wrote:

@arturadib https://github.com/arturadib recently Github guys made it way easier to fix: https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

Can you please go and update A record? Unfortunately, it's ain't something we can contribute ourselves.

At current state broken certificate prevents some of the sites from using strapdown.js properly. Because javascript is served from strapdownjs.com, when browser loads https page that uses strapdown, script is blocked as the mixed content.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arturadib/strapdown/issues/92#issuecomment-431291591, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtQmPumbwIhxGGPfS31xpzs_a9IVz9Fks5umZGGgaJpZM4Wb3Rd .

walterdavis commented 5 years ago

I looked yesterday to see if Strapdown was at CDNJS, and there was an issue (closed) saying that they had asked, but nobody replied. While it's great that you are willing to host it yourself, and to keep the DNS set correctly, maybe letting meadows bloom (by letting it be on all the public CDNs) would lighten the load.

Just a thought,

Walter

On Oct 19, 2018, at 10:56 AM, Artur Adib notifications@github.com wrote:

i've made the A record changes, it needs to propagate though.. fingers crossed. -Artur

On Fri, Oct 19, 2018 at 4:47 AM Kostya Golikov notifications@github.com wrote:

@arturadib https://github.com/arturadib recently Github guys made it way easier to fix: https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

Can you please go and update A record? Unfortunately, it's ain't something we can contribute ourselves.

At current state broken certificate prevents some of the sites from using strapdown.js properly. Because javascript is served from strapdownjs.com, when browser loads https page that uses strapdown, script is blocked as the mixed content.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arturadib/strapdown/issues/92#issuecomment-431291591, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtQmPumbwIhxGGPfS31xpzs_a9IVz9Fks5umZGGgaJpZM4Wb3Rd .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

lazyval commented 5 years ago

@walterdavis as far as I understand, github has it's own CDN for github pages and this is what Arthur is using to host strapdown. How is that compares to CDNJS (I am not a frontend dev per se)?

lazyval commented 5 years ago

So I wrote to github support, and they've expedited certificate creation and now https mode is on!

screenshot 2018-10-22 18-14-43

Horaaay! Thanks to @arturadib and Thomas Baillie from github support

re https support for a site with custom domain name - johnysilver7 gmail com - gmail 2018-10-22 18-16-43
walterdavis commented 5 years ago

CDNJS is a semi-complete collection of front-end software, all of it available elsewhere, which provides diversity and redundancy, at the cost of maybe needing to update your libraries in more than one place. I have put a few libraries there that were abandoned by their creators. I don't know what their policy is about posting maintained software -- who does the updating when a new version comes out? The physical way that it works is you clone the CDNJS repo, make an addition, and send the maintainers a pull request. It usually goes through quickly and automatically if you are already validated. It was years ago that I was validated, though, so who knows what the process is like now.

Walter

On Oct 22, 2018, at 4:25 AM, Kostya Golikov notifications@github.com wrote:

@walterdavis as far as I understand, github has it's own CDN for github pages and this is what Arthur is using to host strapdown. How is that compares to CDNJS (I am not a frontend dev per se)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.