search

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
190 stars 57 forks source link

Ensure that Sinatra loads the SidekiqAlive.config.port #26

Closed bcantin closed 4 years ago

rosskevin commented 4 years ago

Thanks @bcantin for sending a PR. Ran into the same thing.

@arturictus - anything preventing this merge? We just hit this in production when we updated our bundle.

bcantin commented 4 years ago

You should integrate this into a sample app just to be sure it is working properly. We had this in a sample app for a proof of concept. We did not use this library to solve our needs though, we found a different solution by changing our docker configuration.

arturictus commented 4 years ago

Thanks @bcantin for yout PR. Merging...