Set default server to webrick, allow override

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments

MIT License

189 stars 57 forks source link

Set default server to webrick, allow override #34

Closed trevorcreech closed 4 years ago

trevorcreech commented 4 years ago

The Sinatra server inside sidekiq_alive is picking up our project's default puma config, which has a lot of extra stuff (puma worker killer, runs 8 workers, starts up a node SSR server, etc). Running via webrick as a default seems like a reasonable option given this is a very simple, low-traffic http server.

I added an option to override the server if people need to.

i5okie commented 4 years ago

We need this too.

brunozrk commented 4 years ago

What this PR is missing for merge?

arturictus commented 4 years ago

Version 2.0.2 includes this configuration. check #37