Closed sunny closed 4 years ago
Hi @sunny, thanks for your PR, it's great.
I tested it but when I send ^C
it does not stop sidekiq, that means the server is traping the signals.
You can test it with this project: https://github.com/arturictus/sidekiq_alive_example
I added the server config in the version 2.0.2 #37.
This was working before with this code: https://github.com/arturictus/sidekiq_alive/blob/master/lib/sidekiq_alive.rb#L20-L34
Good catch! I've fixed that and it now responds to ^C
correctly on sidekiq_alive_example
.
I also added a configurable path
option (see also #30).
Looks great! :clap: If you just change the config we can merge it
New version released with this changes 2.0.3
:rocket:
Yay, thank you @arturictus for maintaining sidekiq_alive! 🚀
In the same spirit as https://github.com/mperham/sidekiq/pull/3069, this PR removes the Sinatra dependency so as to make this gem slimmer.
Also, allows choosing the web server as suggested in #34