search

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
194 stars 57 forks source link

Remove Sinatra dependency #36

Closed sunny closed 4 years ago

sunny commented 4 years ago

In the same spirit as https://github.com/mperham/sidekiq/pull/3069, this PR removes the Sinatra dependency so as to make this gem slimmer.

arturictus commented 4 years ago

Hi @sunny, thanks for your PR, it's great. I tested it but when I send ^C it does not stop sidekiq, that means the server is traping the signals. You can test it with this project: https://github.com/arturictus/sidekiq_alive_example I added the server config in the version 2.0.2 #37. This was working before with this code: https://github.com/arturictus/sidekiq_alive/blob/master/lib/sidekiq_alive.rb#L20-L34

sunny commented 4 years ago

Good catch! I've fixed that and it now responds to ^C correctly on sidekiq_alive_example.

sunny commented 4 years ago

I also added a configurable path option (see also #30).

arturictus commented 4 years ago

Looks great! :clap: If you just change the config we can merge it

arturictus commented 4 years ago

New version released with this changes 2.0.3 :rocket:

sunny commented 4 years ago

Yay, thank you @arturictus for maintaining sidekiq_alive! 🚀