search

arturictus / sidekiq_alive

Liveness probe for Sidekiq in Kubernetes deployments
MIT License
189 stars 57 forks source link

Custom liveness Probe #40

Closed arturictus closed 3 years ago

arathunku commented 3 years ago

Hey @arturictus, sorry for pinging, I've just found this PR. Is there anything I could help with to get it into master? I'd find it extremely useful. I'm looking for a way to call the logic that I already have on /probe that's used by k8s.

arturictus commented 3 years ago

Hi @arathunku, This branch is an investigation, but it does not occur to me the use cases for adding it to master. How are you using it? The use cases you find will help me to see if this is the best solution. Thanks

arathunku commented 3 years ago

Hey @arturictus,

in our dev k8s cluster, redis/db pods come and go. sidekiq_alive nicely helps with tracking any problems with Redis but I'd like to also check for any problems with connection to postgres database. If DB is no longer available, I want to kill/rotate sidekiq pods.

arathunku commented 3 years ago

Hello @arturictus, is there anything I could help with to push this PR and https://github.com/arturictus/sidekiq_alive/pull/39 forward? We've been using this on production for last few weeks with great success :)

arturictus commented 3 years ago

Hello @arturictus, is there anything I could help with to push this PR and #39 forward? We've been using this on production for last few weeks with great success :)

Hi @arathunku, released version 2.0.6 with both PRs merged. Thanks

arathunku commented 3 years ago

Amazing, thank you!